Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore flash messages #413

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Restore flash messages #413

merged 2 commits into from
Jan 22, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 22, 2021 •
edited
Loading

This reverts commit b62e443 from #401.

Session start is required for flash messages to work:

To test:

  1. configure to use mongodb
  2. visit http://xhgui.127.0.0.1.xip.io:8142/watch
  3. hit "Save"
  4. You should see "Watch functions updated." flash message on the page.

@glensc
Revert "Drop SessionCookie middleware"
a854e04 
This reverts commit b62e443.

Session start is required for flash messages to work
@glensc glensc self-assigned this Jan 22, 2021
@glensc glensc mentioned this pull request Jan 22, 2021
Merged
@glensc glensc added this to the Next milestone Jan 22, 2021
@glensc glensc merged commit 2e2caa9 into master Jan 22, 2021
@glensc glensc deleted the restore-flash-messages branch January 22, 2021 09:06
@glensc glensc mentioned this pull request Jan 25, 2021
Merged
@github-actions github-actions bot mentioned this pull request Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.
1 participant
@glensc